Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upgrade sinon to 3.x (#1491)" #1563

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Revert "Upgrade sinon to 3.x (#1491)" #1563

merged 1 commit into from
Sep 5, 2017

Conversation

jaiminpanchal27
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 commented Sep 5, 2017 •
edited
Loading

Type of change

  • Other

Description of change

This reverts #1491
Unit tests were not starting for IE, Safari and Mobile Safari browsers.
Root cause is unknown but needs more debugging.

prebid-log

IE 11.0.0 (Windows 7 0.0.0) ERROR
  Object expected
  at webpack:///node_modules/lolex/src/lolex-src.js:29:0 <- test/spec/bidmanager_spec.js:12781
�[32m05 09 2017 17:14:03.505:INFO [IE 10.0.0 (Windows 8 0.0.0)]: �[39mConnected on socket Vr4HFPaXiWkKkJChAAAD with id 15392810
�[32m05 09 2017 17:14:03.817:INFO [Safari 7.1.8 (Mac OS X 10.9.5)]: �[39mConnected on socket ok9nzK9enhmx2kUmAAAE with id 30046915
Safari 7.1.8 (Mac OS X 10.9.5) ERROR
  TypeError: undefined is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24
IE 10.0.0 (Windows 8 0.0.0) ERROR
  Unable to get property 'XDomainRequest' of undefined or null reference
  at node_modules/karma-sinon-ie/sinon-ie.js:24
�[32m05 09 2017 17:14:41.582:INFO [Safari 9.1.3 (Mac OS X 10.11.6)]: �[39mConnected on socket 5YsK2p8ZMsKJKjWbAAAF with id 37633531
Safari 9.1.3 (Mac OS X 10.11.6) ERROR
  TypeError: undefined is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24
�[32m05 09 2017 17:14:46.932:INFO [Safari 8.0.8 (Mac OS X 10.10.5)]: �[39mConnected on socket GwyafLepWDHzKX4tAAAG with id 87050481
Safari 8.0.8 (Mac OS X 10.10.5) ERROR
  TypeError: undefined is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24
�[32m05 09 2017 17:15:22.094:INFO [IE 11.0.0 (Windows 10 0.0.0)]: �[39mConnected on socket BsWOHVlaHukGvfewAAAH with id 96542719
�[32m05 09 2017 17:15:22.724:INFO [IE 11.0.0 (Windows 8.1 0.0.0)]: �[39mConnected on socket OIbLi3duP-qMtKQGAAAI with id 57056474
IE 11.0.0 (Windows 10 0.0.0) ERROR
  Object expected
  at webpack:///node_modules/lolex/src/lolex-src.js:29:0 <- test/spec/bidmanager_spec.js:12781
IE 11.0.0 (Windows 8.1 0.0.0) ERROR
  Object expected
  at webpack:///node_modules/lolex/src/lolex-src.js:29:0 <- test/spec/bidmanager_spec.js:12781
�[32m05 09 2017 17:16:38.545:INFO [Mobile Safari 8.0.0 (iOS 8.3.0)]: �[39mConnected on socket -_MVrFfwgaMq8zzOAAAJ with id 22165415
Mobile Safari 8.0.0 (iOS 8.3.0) ERROR
  TypeError: undefined is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24
�[32m05 09 2017 17:16:48.942:INFO [Mobile Safari 7.0.0 (iOS 7.0.0)]: �[39mConnected on socket 2eTtTmB-ArHW8xx-AAAK with id 35790609
Mobile Safari 7.0.0 (iOS 7.0.0) ERROR
  TypeError: 'undefined' is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24
�[32m05 09 2017 17:17:04.466:INFO [Mobile Safari 9.0.0 (iOS 9.3.0)]: �[39mConnected on socket -dZel5hSYj6C9ocSAAAL with id 56052992
Mobile Safari 9.0.0 (iOS 9.3.0) ERROR
  TypeError: undefined is not an object (evaluating 'sinon.xdr.XDomainRequest')
  at node_modules/karma-sinon-ie/sinon-ie.js:24

Edge 14.14393.0 (Windows 10 0.0.0): Executed 1075 of 1334 (5 FAILED) (skipped 1) (7.75 secs / NaN secs)
IE 10.0.0 (Windows 7 0.0.0): Executed 0 of 0 ERROR (0.455 secs / 0 secs)
IE 11.0.0 (Windows 7 0.0.0): Executed 0 of 0 ERROR (5.006 secs / 0 secs)
IE 10.0.0 (Windows 8 0.0.0): Executed 0 of 0 ERROR (1.429 secs / 0 secs)
Safari 7.1.8 (Mac OS X 10.9.5): Executed 0 of 0 ERROR (1.026 secs / 0 secs)
Safari 9.1.3 (Mac OS X 10.11.6): Executed 0 of 0 ERROR (0.637 secs / 0 secs)
Safari 8.0.8 (Mac OS X 10.10.5): Executed 0 of 0 ERROR (0.723 secs / 0 secs)
IE 11.0.0 (Windows 10 0.0.0): Executed 0 of 0 ERROR (1.329 secs / 0 secs)
IE 11.0.0 (Windows 8.1 0.0.0): Executed 0 of 0 ERROR (1.783 secs / 0 secs)
Mobile Safari 8.0.0 (iOS 8.3.0): Executed 0 of 0 ERROR (1.641 secs / 0 secs)
Mobile Safari 7.0.0 (iOS 7.0.0): Executed 0 of 0 ERROR (1.269 secs / 0 secs)
Mobile Safari 9.0.0 (iOS 9.3.0): Executed 0 of 0 ERROR (1.319 secs / 0 secs)

@jaiminpanchal27 jaiminpanchal27 merged commit 15612ff into master Sep 5, 2017
philipwatson pushed a commit to mbrtargeting/Prebid.js that referenced this pull request Sep 18, 2017
@jaiminpanchal27 @philipwatson
Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563)
d2e4a38 
This reverts commit dc4736a.
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Sep 18, 2017
Merge tag '0.28.0' of https://github.com/prebid/Prebid.js into prebuilt
da960cc 
* tag '0.28.0' of https://github.com/prebid/Prebid.js: (27 commits)
  Prebid 0.28.0 Release
  Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563)
  add () for correct order of operations in scaling increments for currency (prebid#1559)
  AppnexusAst adapter update: Added source and version to request payload (prebid#1555)
  remove unnecessary spread operator (prebid#1561)
  Adxcg adapter (prebid#1554)
  Upgrade sinon to 3.x (prebid#1491)
  Rename vastPayload to vastXml (prebid#1556)
  Single-size sizes array now can be taken, too (prebid#1535)
  Updated the istanbul-instrumenter-loader (prebid#1550)
  Add AerServ Adapter (prebid#1538)
  Fixed imports and made adform support aliasing (prebid#1518)
  Custom granularity fix (prebid#1546)
  Fix `documentation lint` issues (prebid#1544)
  Yieldbot adunit bidder params slot name usage fix (prebid#1394)
  Update serverbid adapter to use smartsync (prebid#1324)
  Add improvedigitalBidAdapter (prebid#1381)
  Fix prebid#1533 spring server typo (prebid#1542)
  userSync is off by default (prebid#1543)
  currency module (prebid#1374)
  ...
@matthewlane matthewlane deleted the revert-sinon-upgrade branch September 19, 2017 16:25
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Oct 12, 2017
@vzhukovsky
Merge pull request prebid#121 in AOLP_ADS_JS/prebid.js from release/1…
e797d03 
….28.0 to aolgithub-master

* commit '4d9ade3df767750743f8888ed9efd6c77f8d0050': (26 commits)
  Added changelog entry.
  Added new aol partners ids.
  Prebid 0.28.0 Release
  Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563)
  add () for correct order of operations in scaling increments for currency (prebid#1559)
  AppnexusAst adapter update: Added source and version to request payload (prebid#1555)
  remove unnecessary spread operator (prebid#1561)
  Adxcg adapter (prebid#1554)
  Upgrade sinon to 3.x (prebid#1491)
  Rename vastPayload to vastXml (prebid#1556)
  Single-size sizes array now can be taken, too (prebid#1535)
  Updated the istanbul-instrumenter-loader (prebid#1550)
  Add AerServ Adapter (prebid#1538)
  Fixed imports and made adform support aliasing (prebid#1518)
  Custom granularity fix (prebid#1546)
  Fix `documentation lint` issues (prebid#1544)
  Yieldbot adunit bidder params slot name usage fix (prebid#1394)
  Update serverbid adapter to use smartsync (prebid#1324)
  Add improvedigitalBidAdapter (prebid#1381)
  Fix prebid#1533 spring server typo (prebid#1542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaiminpanchal27